libotutil: Avoid infinite recursion during error unwinding
authorSimon McVittie <smcv@collabora.com>
Fri, 28 Jan 2022 11:08:00 +0000 (11:08 +0000)
committerSimon McVittie <smcv@collabora.com>
Fri, 28 Jan 2022 11:08:00 +0000 (11:08 +0000)
commit920f85cabc656e4a7c07574aa9af211b6153756d
tree098b49ab80f5debee59011fa2531d3a5f952cd25
parent10ddf6e25fed1a4f6bd2bd04606130ff235dded2
libotutil: Avoid infinite recursion during error unwinding

When we clean up from an error, for example copy_file_range() failing
while we generate a static delta (perhaps caused by
https://gitlab.gnome.org/GNOME/libglnx/-/issues/3 or by a
genuine write error), we might free a variant builder that has a
non-null parent. Previously, this caused infinite recursion and a stack
overflow, repeatedly freeing the same object, but Luca Bruno suggested
that the intention here appears to have been to free the parent object.

Partially resolves https://github.com/ostreedev/ostree/issues/2525
(the other bug reported in that issue needs to be resolved by updating
libglnx to a version where libglnx#3 has been fixed).

Signed-off-by: Simon McVittie <smcv@collabora.com>
src/libotutil/ot-variant-builder.c